Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... version_util: allow period as delimiter in extra and tighten version syntax This will permit versions like <major>.<minor>.<maintenance>.<vendor_ver>, a common pattern used by at least one Kudu vendor. The change shouldn't have any tangible effect upstream as we've always ignored the value of 'extra'. The string splitting wasn't cutting it for me so I rewrote the parsing to use POSIX extended regexes. The major side effect is that we're no longer loosey goosey with components (i.e. "1. 2 . 3" or "+1.+2.+3"); each must be a subsequence of nothing but digits. I don't think anyone was relying on this excessive permissiveness and I find the new code to be more readable. Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Reviewed-on: http://gerrit.cloudera.org:8080/13897 Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/version_util-test.cc M src/kudu/util/version_util.cc M src/kudu/util/version_util.h 3 files changed, 46 insertions(+), 24 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]>
