Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13897/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13897/3//COMMIT_MSG@16 PS3, Line 16: I don't think anyone was relying on : this excessive permissiveness and I find the new code to be more readable. +1 http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util-test.cc File src/kudu/util/version_util-test.cc: http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util-test.cc@a48 PS3, Line 48: : : : It's nice these are no longer 'valid' version strings: they were too weird, but it was necessary to explicitly document how the prior version of the parser works, so they ended up here. -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 00:14:59 +0000 Gerrit-HasComments: Yes
