Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/13937/7/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/13937/7/src/kudu/tools/ksck.h@452 PS7, Line 452: // Setters for filtering the tables/tablets to be checked. : // Equivalent to the same functions in class 'Ksck'. : void set_table_filters(std::vector<std::string> table_names) { : table_filters_ = std::move(table_names); : } : : // See above. : void set_tablet_id_filters(std::vector<std::string> tablet_ids) { : tablet_id_filters_ = std::move(tablet_ids); > Rather than duplicating all of this, could you just refer to the equivalent Done http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc@502 PS5, Line 502: msg += " Filter:"; > Yeah I'm not sure I understand either; it seems like num_replicas_tmp shoul I tested several cases and finally got the following results: If there are tablets in a cluster and all tablets filtered out, the result is 'No tablet replicas found' error. If there are table(s) but no tablet in a cluster(i.e. all range partitions have been dropped), the result is 'OK'. The comment 'Warn if the table has tablets, but no replicas.' is confusing, is it possible 'the table has tablets but no replicas'? However in this patch, the 'cluster_' here is not complete, it only includes unfiltered tables/tablets, so in both cases the checksum result is 'No tablet replicas found' error. I think it's not necessary to distinguish between the two cases. -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 8 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2019 04:18:24 +0000 Gerrit-HasComments: Yes
