Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc@502 PS5, Line 502: // The table may have no tablets if all range partitions have been dropped. > Why should this be an error? If there were tablets but the user filtered them > all out, shouldn't this be Status::OK? Maybe the error could tell users they set wrong filters. > Would it be difficult to add tracking of the list of filtered tables/tablets > in KsckCluster, and then use it to differentiate between the two cases here? Well, if we do this we actually track all tables and tablets, which was same as before. But the idea of this patch is to track less tables and tablets in KsckCluster to accelerate the execution of ksck tool. However, in ordered to differentiate between the two cases here, I added two variables named 'filtered_tables_count' and 'filtered_tablets_count' to KsckCluster. Besides I added some unit tests to coverage different cases, including the cluster has no table, the cluster has tables but all tables filtered out, the cluster has a table with no tablet, the cluster has a table with tablets but all tablets filtered out. -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 9 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2019 11:48:00 +0000 Gerrit-HasComments: Yes
