Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 9: (4 comments) The TSAN test failure looks real: a data race in the new code in KsckCluster. http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck.h@471 PS9, Line 471: const int32_t& filtered_tables_count() const { : return filtered_tables_count_; : } : : const int32_t& filtered_tablets_count() const { : return filtered_tablets_count_; : } Value types (i.e. int, double, etc.) should be returned by value rather than by cref. http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck.h@489 PS9, Line 489: int32_t filtered_tables_count_; : int32_t filtered_tablets_count_; Nit: 'int' is fine too. http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck_checksum.cc@491 PS9, Line 491: &&n && n http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/13937/9/src/kudu/tools/ksck_remote.cc@526 PS9, Line 526: filtered_tables_count_ = 0; Should probably also initialize these new variables to 0 in the constructor so that they aren't garbage before RetrieveTablesList or RetrieveTabletsList are called. -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 9 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2019 17:37:50 +0000 Gerrit-HasComments: Yes
