Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/13937/11/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/13937/11/src/kudu/tools/ksck_remote.cc@525 PS11, Line 525: uint32_t tables_count = 0; Nit: no real reason for this to be unsigned; could you just make it regular int? http://gerrit.cloudera.org:8080/#/c/13937/11/src/kudu/tools/ksck_remote.cc@580 PS11, Line 580: Status RemoteKsckCluster::RetrieveTabletsList(const shared_ptr<KsckTable>& table) { The logic for filtered_tablets_count_ here is incorrect because RetrieveTabletsList is called _for each table_. Maybe you meant to initialize filtered_tablets_count_ to 0 in RetrieveAllTablets? Also curious why this wasn't caught by a unit test. Do we never exercise the parallelism here? -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 11 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 05:25:30 +0000 Gerrit-HasComments: Yes
