Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/13937/11/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/13937/11/src/kudu/tools/ksck-test.cc@1244 PS11, Line 1244: cluster_->set_table_filters({"xyz"}); Table filter and tablet filter are now performed in KsckCluster class, not Ksck class. And unit tests are testing MockKsckCluster, but RemoteKsckCluster class which is used by CLI tool hasn't been tested, right? -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 11 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 06:03:37 +0000 Gerrit-HasComments: Yes
