Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979 Add wrap up function of krb5_parse_name, so it can be called from Impala ...................................................................... Patch Set 2: (5 comments) I know the intent isn't to use this within Kudu, but could you at least add a simple unit test so we don't accidentally break this functionality for Impala in the future? http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@7 PS2, Line 7: KUDU-2979 Add wrap up function of krb5_parse_name, so it can be called from Impala Format as "KUDU-2979: ..." Also, I think "wrapper" function is more appropriate than "wrap up". So maybe this should be "Add wrapper function for krb5_parse_name to be used in Impala"? http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@9 PS2, Line 9: Nit: got two spaces here http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@13 PS2, Line 13: wrap up wrapper http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@16 PS2, Line 16: Krb5parseName(const string& principal, string* service_name, : string* hostname, string* realm) I think this is too much detail given the simplicity of the patch. If someone wants to see the function signature you chose, it's right there in init.h. http://gerrit.cloudera.org:8080/#/c/14520/2/src/kudu/security/init.h File src/kudu/security/init.h: http://gerrit.cloudera.org:8080/#/c/14520/2/src/kudu/security/init.h@38 PS2, Line 38: // Convert a string representation of a principal name to a krb5_principal structure. : // And get service_name, hostname, realm from it. The krb5_principal part seems like an implementation detail not worth documenting. Perhaps: // Parses the given Kerberos principal into a service name, hostname, and realm. -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 2 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 22 Oct 2019 03:55:01 +0000 Gerrit-HasComments: Yes
