Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc@460 PS3, Line 460: realm.data > Here and elsewhere below: is this guaranteed that 'data' field of the krb5_ I checked that the char array ends with 0'\000'. For using length, do you mean using a for loop? Is there a one line function to convert char array to string? http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc@461 PS3, Line 461: const krb5 > nit: add 'const' Done http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc@466 PS3, Line 466: SCOPED_CLEANUP({ > I think it's cleaner to add a scoped clean-up just after calling krb5_parse Done -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2019 22:24:39 +0000 Gerrit-HasComments: Yes
