Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@16 PS2, Line 16: ParseKerberosPrincipal method. : > The issue is that without Kudu tests we won't know if we've broken this fun +1 http://gerrit.cloudera.org:8080/#/c/14520/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14520/3//COMMIT_MSG@9 PS3, Line 9: We nit: we http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc@466 PS3, Line 466: krb5_free_principal(g_krb5_ctx, princ); I think it's cleaner to add a scoped clean-up just after calling krb5_parse_name(): SCOPED_CLEANUP({ krb5_free_principal(g_krb5_ctx, princ); }); -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 17:24:25 +0000 Gerrit-HasComments: Yes
