Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc@460 PS3, Line 460: realm.data Here and elsewhere below: is this guaranteed that 'data' field of the krb5_data structure is null-terminated? Why not to use krb5_data.length field when copying from a krb5_data.data C-string? Would it be safer? http://gerrit.cloudera.org:8080/#/c/14520/3/src/kudu/security/init.cc@461 PS3, Line 461: krb5_data* nit: add 'const' const krb5_data* -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 17:44:14 +0000 Gerrit-HasComments: Yes
