Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@16 PS2, Line 16: ParseKerberosPrincipal method. : > I added test in impala https://gerrit.cloudera.org/#/c/14433/. For kudu, is The issue is that without Kudu tests we won't know if we've broken this function until Impala next merges changes from krpc. It'll be frustrating to deal with breakages at that time. How about making changes to mini_kdc-test? TestBasicOperation seems like a great place to call the new function, as it already does a bunch of stuff that sets up a krb5 context. -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 03:42:40 +0000 Gerrit-HasComments: Yes
