Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@7 PS2, Line 7: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala > Format as "KUDU-2979: ..." Done http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@9 PS2, Line 9: _p > Nit: got two spaces here Done http://gerrit.cloudera.org:8080/#/c/14520/2//COMMIT_MSG@16 PS2, Line 16: ParseKerberosPrincipal method. : > I think this is too much detail given the simplicity of the patch. If someo I added test in impala https://gerrit.cloudera.org/#/c/14433/. For kudu, is there any test class I can use to add test? What I find in kudu is using kdc.Kinit(). http://gerrit.cloudera.org:8080/#/c/14520/2/src/kudu/security/init.h File src/kudu/security/init.h: http://gerrit.cloudera.org:8080/#/c/14520/2/src/kudu/security/init.h@38 PS2, Line 38: // Parses the given Kerberos principal into service name, hostname, and realm. : Status Krb5ParseName(const std::string& principal > The krb5_principal part seems like an implementation detail not worth docum Done -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 01:17:58 +0000 Gerrit-HasComments: Yes
