Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/14760/10/src/kudu/fs/block_manager_util.h File src/kudu/fs/block_manager_util.h: http://gerrit.cloudera.org:8080/#/c/14760/10/src/kudu/fs/block_manager_util.h@55 PS10, Line 55: // > I don't feel strongly about it, but I always viewed this class as a thin OO I see. I agree it's thin (though it's grown thicker), but the deciding question for me is, "If protobuf had a 'set' primitive, would we use that here?", and I think the answer is yes. It is the "path set" after all. http://gerrit.cloudera.org:8080/#/c/14760/11/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/14760/11/src/kudu/fs/fs_manager.cc@395 PS11, Line 395: const static string kUnableToCreateMsg = "unable to create missing filesystem roots"; > Nit: declare it static too. Done -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 00:42:12 +0000 Gerrit-HasComments: Yes
