Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/14760/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14760/10//COMMIT_MSG@10 PS10, Line 10: By default > In such cases, I don't think the flag would help because with the previous The point is that manual operations (like running update_dirs tool) is something that is performed _explicitly_. That resembles a bit the initialization of the directory structure upon the very first run of a tablet server. Also, when introducing a new feature or a non-backwards-compatible behavior, in most cases it makes sense to have a flag to return to the old behavior in the case if something was overlooked. If the consensus is that this change is completely safe and there is no difference in cases when a tablet server starts after drive/directory failure and a regular stop/start, then I don't think there is a need to continue this discussion: if somebody requests to get back to the older behavior, it's possible to implement that flag in the future versions. -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 06:49:37 +0000 Gerrit-HasComments: Yes
