Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/14760/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14760/10//COMMIT_MSG@10 PS10, Line 10: By default I don't have good understanding of the matter, but I have one quick question. Does it make sense to make this new behavior non-default? My concern is various cases of fat-fingering accidents while updating the list of data directories. E.g., the former valid and consistent directory had been re-mounted under different path, but they forgot to update the list of directories, and the former path is just an empty directory now at, say, the root filesystem. Maybe, it would be safer to switch to the new behavior only some flag is flipped explicitly? That might be the case when recovering from a drive failure. -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 04:14:19 +0000 Gerrit-HasComments: Yes
