Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/14760/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14760/10//COMMIT_MSG@10 PS10, Line 10: By default > I don't think "fat-fingering" is common enough to warrant the operational o To add to what Andrew said, we've accumulated several releases worth of user feedback for this feature, and nearly all of it corroborates Andrew's observations. Moreover, Kudu will recover reasonably well from a fat-fingered removal of a data directory: somewhere between 1/3rd to all of the hosted replicas will fail, and they'll get rereplicated elsewhere in the cluster. http://gerrit.cloudera.org:8080/#/c/14760/15/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/14760/15/src/kudu/tools/tool_action_fs.cc@131 PS15, Line 131: fs_opts.update_instances = UpdateInstanceBehavior::DONT_UPDATE; Do we want to condition this on FLAGS_repair? -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 05:26:01 +0000 Gerrit-HasComments: Yes
