Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/14760/15/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/14760/15/src/kudu/tools/tool_action_fs.cc@131 PS15, Line 131: fs_opts.update_instances = UpdateInstanceBehavior::DONT_UPDATE; > Do we want to condition this on FLAGS_repair? Hrm, I could go either way, but I'm leaning towards no. These repairs are currently aimed at repairing blocks. We could, but it'd be somewhat redundant with update_dirs. -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 05:37:13 +0000 Gerrit-HasComments: Yes
