Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] return non-zero status from main() instead of crashing ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14908/1/src/kudu/util/logging.h File src/kudu/util/logging.h: http://gerrit.cloudera.org:8080/#/c/14908/1/src/kudu/util/logging.h@371 PS1, Line 371: const auto& _s = (s); \ : if (!_s.ok()) { \ : const auto& ss = _s.CloneAndPrepend((msg)); \ How can we store the results of expression evaluation in crefs? Shouldn't the LHS here be "const auto"? -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 13 Dec 2019 23:16:27 +0000 Gerrit-HasComments: Yes
