Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] return non-zero status from main() instead of crashing ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG@17 PS1, Line 17: In most cases, core dumps were disabled, and only minidumps were : available from processes crashed in such cases. > I'm not very familiar with core dumps -- does this mean that when Kudu retu Nope, that means that instead of crashing (and creating a core file, if storing core file from crashed processes is enabled), with this patch Kudu masters and tablet servers return non-zero return code from their main() function. http://gerrit.cloudera.org:8080/#/c/14908/1/src/kudu/util/logging.h File src/kudu/util/logging.h: http://gerrit.cloudera.org:8080/#/c/14908/1/src/kudu/util/logging.h@371 PS1, Line 371: const auto& _s = (s); \ : if (!_s.ok()) { \ : const auto& ss = _s.CloneAndPrepend((msg)); \ > How can we store the results of expression evaluation in crefs? Shouldn't t We can: that's a C++ feature. In fact, the same code is in RETURN_NOT_OK() macro definition: https://github.com/apache/kudu/blob/8c069b3f9d9ac6cb664e0f30b879461d6b40efee/src/kudu/util/status.h#L35-L38 But it doesn't bring us much here anyways and I forgot how it's called (so I cannot find a link to the spec really fast). I will change it to LHS-like expression. Hopefully, that will be less confusion. -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 14 Dec 2019 00:04:02 +0000 Gerrit-HasComments: Yes
