Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] return non-zero status from main() instead of crashing ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG@17 PS1, Line 17: In most cases, core dumps were disabled, and only minidumps were : available from processes crashed in such cases. > Ah, so this is saying that before we would get minidumps, but they weren't Corefiles don't help debug issues in Init/Start? In case of SIGARBT the process I think exits with exit code 142 whereas now it'll exit with codes 2/3. Agreed both are non-zero exit codes, can you make sure(in theory in commit message is fine) they won't cause problems/regress behavior with process mgmt software like systemd/CM agent in terms of restarting a failed process? -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Dec 2019 20:12:39 +0000 Gerrit-HasComments: Yes
