Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] return non-zero status from main() instead of crashing ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG@17 PS1, Line 17: In most cases, core dumps were disabled, and only minidumps were : available from processes crashed in such cases. > Ah, so this is saying that before we would get minidumps, but they weren't Yes, correct: if kudu-master or kudu-tserver crashes and there is just minidump generated (but coredumps are disabled), not much information is avalable to troubleshoot the problem anyways. Also, the whole premise of crashing in such cases doesn't seem to be really appealing, because it's easy to handle the situation pretty easy: just return non-zero from main(). I think I'll modify this micropatch to use LOG(DFATAL) instead of LOG(ERROR) for RETURN_MAIN_NOT_OK -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Dec 2019 20:36:57 +0000 Gerrit-HasComments: Yes
