Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] return non-zero status from main() instead of crashing ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG@17 PS1, Line 17: In most cases, core dumps were disabled, and only minidumps were : available from processes crashed in such cases. > Yes, correct: if kudu-master or kudu-tserver crashes and there is just mini Ah, scratch that: I'm not sure whether dumping a core makes sense at all in such cases. That's what the stack looks like (and I'm not sure there is much we ca get from it): #0 0x00007f2445c691f7 in raise () from ./lib64/libc.so.6 #1 0x00007f2445c6a8e8 in abort () from ./lib64/libc.so.6 #2 0x0000000001bcf1e9 in kudu::AbortFailureFunction () at /usr/src/debug/kudu-1.7.0-cdh5.15.1/src/kudu/util/minidump.cc:190 #3 0x0000000000902fad in google::LogMessage::Fail () at /usr/src/debug/kudu-1.7.0-cdh5.15.1/thirdparty/src/glog-0.3.5/src/logging.cc:1488 #4 0x0000000000904f03 in google::LogMessage::SendToLog (this=0x7ffc44ffb3c0) at /usr/src/debug/kudu-1.7.0-cdh5.15.1/thirdparty/src/glog-0.3.5/src/logging.cc:1442 #5 0x0000000000902b09 in google::LogMessage::Flush (this=this@entry=0x7ffc44ffb3c0) at /usr/src/debug/kudu-1.7.0-cdh5.15.1/thirdparty/src/glog-0.3.5/src/logging.cc:1311 #6 0x000000000090588f in google::LogMessageFatal::~LogMessageFatal (this=0x7ffc44ffb3c0, __in_chrg=<optimized out>) at /usr/src/debug/kudu-1.7.0-cdh5.15.1/thirdparty/src/glog-0.3.5/src/logging.cc:2023 #7 0x000000000089c9c3 in kudu::master::MasterMain (argc=1, argv=0x7ffc44ffbb60) at /usr/src/debug/kudu-1.7.0-cdh5.15.1/src/kudu/master/master_main.cc:74 #8 0x00007f2445c55c05 in __libc_start_main () from ./lib64/libc.so.6 #9 0x000000000089c3c5 in _start () -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Dec 2019 23:41:53 +0000 Gerrit-HasComments: Yes
