Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] return non-zero status from main() instead of crashing ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG@17 PS1, Line 17: In most cases, core dumps were disabled, and only minidumps were : available from processes crashed in such cases. > Nope, that means that instead of crashing (and creating a core file, if sto Ah, so this is saying that before we would get minidumps, but they weren't very useful anyway because of the stripped heap, so there's no point in crashing. Is that right? -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Dec 2019 19:41:06 +0000 Gerrit-HasComments: Yes
