Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] non-zero code from main() instead of crashing ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14908/4/src/kudu/util/logging.h File src/kudu/util/logging.h: PS4: > Have you considered putting this in util/status.h instead? Looking at what Nope, I haven't. But indeed, it seems util/status.h a better place for this macro. Done. http://gerrit.cloudera.org:8080/#/c/14908/4/src/kudu/util/logging.h@369 PS4, Line 369: > nit: maybe consider using 's' as the first argument? That way it's consiste Good point. Done. -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Dec 2019 21:21:57 +0000 Gerrit-HasComments: Yes
