Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14908 )
Change subject: [master/tserver] non-zero code from main() instead of crashing ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14908/1//COMMIT_MSG@17 PS1, Line 17: behavior and their address space: just return non-zero from main() : function. > Ah, scratch that: I'm not sure whether dumping a core makes sense at all in Ah, yeah that doesn't seem useful at all. Removing it sgtm! http://gerrit.cloudera.org:8080/#/c/14908/4/src/kudu/util/logging.h File src/kudu/util/logging.h: PS4: Have you considered putting this in util/status.h instead? Looking at what else is defined in util/logging.h, there's a bit of a disconnect between it and RETURN_MAIN_NOT_OK http://gerrit.cloudera.org:8080/#/c/14908/4/src/kudu/util/logging.h@369 PS4, Line 369: #define RETURN_MAIN_NOT_OK(ret_code, s, msg) do { \ nit: maybe consider using 's' as the first argument? That way it's consistent with most of the things in util/status.h -- To view, visit http://gerrit.cloudera.org:8080/14908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id06646e2211eb24db28c582455d4a34af7501b26 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Dec 2019 20:51:17 +0000 Gerrit-HasComments: Yes
