Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] fix the java binary path for the subprocess ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@41 PS1, Line 41: "", Does this mean this flag should always be set because the default value doesn't allow to run java since java is not usually available as /bin/java ? http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@41 PS1, Line 41: java_home nit: maybe rename into 'ranger_java_home' to match the rest of the flags? http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: subprocess_ > Doesn't the path get eaten up by the basename call here? It's eaten just for the first element of argv list for execvp(); but the binary image uses the full path passed to subprocess_. -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 06:22:50 +0000 Gerrit-HasComments: Yes
