Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] fix the java binary path for the subprocess ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15415/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15415/2//COMMIT_MSG@7 PS2, Line 7: [ranger] fix the java binary path for the subprocess Wouldn't you rather say that you're parameterizing the Java binary path? I don't see how the patch "fixes" it per se. http://gerrit.cloudera.org:8080/#/c/15415/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/2/src/kudu/ranger/ranger_client.cc@41 PS2, Line 41: DEFINE_string(java_path, "java", This should include a note about how if the value isn't an absolute path, it'll be evaluated using the Kudu user's PATH. -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 22:48:15 +0000 Gerrit-HasComments: Yes
