Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] fix the java binary path for the subprocess ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Nothing to add to Alexey's comments http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: subprocess_ > It's eaten just for the first element of argv list for execvp(); but the bi Ah, I see; we make a copy of argv[0]. Thanks for clarifying! -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 17:28:28 +0000 Gerrit-HasComments: Yes
