Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] parameterize the Java binary path for the subprocess ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/15415/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15415/2//COMMIT_MSG@7 PS2, Line 7: [ranger] parameterize the Java binary path for the subprocess > Wouldn't you rather say that you're parameterizing the Java binary path? I Done http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@41 PS1, Line 41: _pa > Does this mean this flag should always be set because the default value doe I updated in patch 2 based on Andrew's recommendation to java_path. With the new default 'java', so this is not required to set if kudu user's PATH is configured with where Java binary is located. http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@41 PS1, Line 41: ranger_ja > nit: maybe rename into 'ranger_java_home' to match the rest of the flags? Done http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: HISTINIT(sp > Ah, I see; we make a copy of argv[0]. Thanks for clarifying! Done http://gerrit.cloudera.org:8080/#/c/15415/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/2/src/kudu/ranger/ranger_client.cc@41 PS2, Line 41: DEFINE_string(ranger_java_path, "java", > This should include a note about how if the value isn't an absolute path, i Done -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 14 Mar 2020 18:50:20 +0000 Gerrit-HasComments: Yes
