Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17129 )
Change subject: KUDU-3248: Match C++ replica selection behavior of Java client ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-internal.cc@126 PS2, Line 126: )); > nit: drop Done http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-internal.cc@134 PS2, Line 134: while (1) { > Better to move this close where it's first used in SelectTServer() function Done http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-internal.cc@134 PS2, Line 134: { > nit: kNamingConvention? per https://google.github.io/styleguide/cppguide.ht Done http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-internal.cc@134 PS2, Line 134: whil > nit: could also be const Done http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-test.cc@2614 PS2, Line 2614: // Marking stale forces a lookup. > nit: maybe comment that marking staleness forces a lookup? Done http://gerrit.cloudera.org:8080/#/c/17129/2/src/kudu/client/client-test.cc@2637 PS2, Line 2637: RemoteT > Should be c2? Done -- To view, visit http://gerrit.cloudera.org:8080/17129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Gerrit-Change-Number: 17129 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 19:39:56 +0000 Gerrit-HasComments: Yes
