Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17129 )
Change subject: KUDU-3248: Match C++ replica selection behavior of Java client ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17129/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/17129/3/src/kudu/client/client-internal.cc@191 PS3, Line 191: still benefit from spreading the load across replicas > Why not to have this per client? I think that making it the same for all c I meant we already have a recommendation to have just a single client per application. So, if for some reason it it's necessary to escape from this affinity in the same application, keeping this per-process makes it impossible. However, if this were an affinity per client instance, then in case if this affinity is not desired, at least there is a choice to instantiate multiple clients. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/17129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Gerrit-Change-Number: 17129 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 19:55:47 +0000 Gerrit-HasComments: Yes
