Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 6: (1 comment) > Patch Set 4: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/17674/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17674/4//COMMIT_MSG@14 PS4, Line 14: unit tests > It would be great to add a test for the meta-cache in the KuduClient, and a It's good to wait all necessary replicas running and then Alter() return, but I found some difficulties to implement it. A table state transfer from ALTERING to RUNNING needs all tablets' schema version changed to desired version, this rule is not adapt when change replication factor. For example, change RF from 1 to 3, the old leader replica will report immediatly before all 3 replicas under replicated, but we will still transfer from ALTERING to RUNNING. So whether to keep all replicas' schema version instead of tablets', wihch is another big modification, we would better disscuss clearly at first. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 16 Jul 2021 09:37:05 +0000 Gerrit-HasComments: Yes
