Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@173 PS1, Line 173: HashDimension > We still might need to store the end range key for adding/dropping range pa Well, I guess that's what https://gerrit.cloudera.org/#/c/17779/ is about :) As for making it a dictionary/map keyed by start range, after some consideration I'm not sure the benefits are greater than the drawbacks of duplicating information about the start of the range. -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 18 Aug 2021 02:01:13 +0000 Gerrit-HasComments: Yes
