Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@173 PS1, Line 173: HashDimension > I guess as long as the 'ranges_with_hash_schemas' field is persisted within Ah, you meant to use that new field only when deserializing the field from storage, I see. That might be an option -- we can consider that down the road. >From the other side, if going that route, maybe we should replace >PartitionSchemaPB::range_hash_schemas and PartitionSchemaPB::range_bounds with >a single dictionary that has the start range as the key and the hash schema >for the range as value? -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Aug 2021 23:45:11 +0000 Gerrit-HasComments: Yes
