Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/client.cc@967 PS2, Line 967: for (const auto& p : data_->range_partitions_) { > Ah oops, seems I didn't highlight "partition", since we're making the trans Well, I guess the code is self-evident here, so removing this comment makes sense as well :) http://gerrit.cloudera.org:8080/#/c/17775/4/src/kudu/client/table_creator-internal.h File src/kudu/client/table_creator-internal.h: http://gerrit.cloudera.org:8080/#/c/17775/4/src/kudu/client/table_creator-internal.h@50 PS4, Line 50: const uint32_t num_buckets; : const uint32_t seed; > To be consistent with 'HashBucketSchemaPB', shouldn't this be Done http://gerrit.cloudera.org:8080/#/c/17775/4/src/kudu/client/table_creator-internal.h@102 PS4, Line 102: int32_t seed) > Should be unsigned. Done http://gerrit.cloudera.org:8080/#/c/17775/4/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17775/4/src/kudu/common/partition.cc@325 PS4, Line 325: int32_t > change to 'uint32_t' Changed to 'auto'. http://gerrit.cloudera.org:8080/#/c/17775/4/src/kudu/common/partition.cc@698 PS4, Line 698: int32_t > change to 'uint32_t' changed to 'auto' -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 18 Aug 2021 00:24:25 +0000 Gerrit-HasComments: Yes
