Hello Mahesh Reddy, Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17775
to look at the new patch set (#5).
Change subject: [partition] update naming of related entities
......................................................................
[partition] update naming of related entities
With this patch, the naming for the partition-related entities
in the C++ code has changed:
* renamed HashBucketSchema into HashDimension
* renamed HashBucketSchemas into HashSchema, so HashSchema is now
a typedef for std::vector<HashDimension>
* partitioning schema --> partition schema
* hash bucket schema --> hash schema
* hash partitioning schema --> hash schema
* range partition schema --> range schema
* hash_bucket_schemas_ --> hash_schema_
* removed the PerRangeHashBucketSchemas typedef
The idea is to represent the hash-related component of the partition
schema as a set of hash bucket dimensions. Before, it was called
'hash bucket schemas' to be 1-to-1 mapping with the
PartitionSchemaPB::HashBucketSchemaPB protobuf message defined in
common.proto. I found it a bit awkward calling a single dimension of
hash bucketing 'schema' because it's semantically confusing, since
'schema' usually means the whole set of rules, not just a part of those.
It would be nice to update the proto-related names as well, but doing so
would break backwards compatibility.
I also updated the in-line documentation for the partition-related
entities in the PartitionSchema's class-wide comment and added TODOs
where more updates are required to accommodate the recent changes
introduced in the context of KUDU-2671.
Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033
---
M src/kudu/client/client.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/partition_pruner.h
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_perf.cc
18 files changed, 421 insertions(+), 389 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/17775/5
--
To view, visit http://gerrit.cloudera.org:8080/17775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033
Gerrit-Change-Number: 17775
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
