Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 21: Code-Review+1 (2 comments) > Patch Set 21: > > (2 comments) This patch is good overall except the tests didn't actually verify the functionality (in my opinions). I give my +1 but I'd like you to improve the tests. http://gerrit.cloudera.org:8080/#/c/18054/21/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/21/src/kudu/tablet/tablet_mm_ops-test.cc@102 PS21, Line 102: all_possible_metrics_ > I don't think it's necessary to distinguish all the metrics. Because in thi We only disable compaction on the tablet, so why all metrics should not change? http://gerrit.cloudera.org:8080/#/c/18054/21/src/kudu/tablet/tablet_mm_ops-test.cc@108 PS21, Line 108: UpdateStats > I've just tested and will fail when we enable compaction. The changes like The tests failed because this 'ASSERT_TRUE(op.DisableCompact())' failed, if this assert was removed, tests will pass. That means, we don't really test 'the metrics didn't change because we disable compaction on the tablet' in the tests. -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 21 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 06 Jan 2022 05:37:47 +0000 Gerrit-HasComments: Yes
