KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/18054/21/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/21/src/kudu/tablet/tablet_mm_ops-test.cc@102 PS21, Line 102: all_possible_metrics_ > We only disable compaction on the tablet, so why all metrics should not cha Oh,I see what you mean. http://gerrit.cloudera.org:8080/#/c/18054/21/src/kudu/tablet/tablet_mm_ops-test.cc@108 PS21, Line 108: UpdateStats > The tests failed because this 'ASSERT_TRUE(op.DisableCompact())' failed, if Yes, you are right.I'll improve this test. -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 21 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 06 Jan 2022 06:17:17 +0000 Gerrit-HasComments: Yes
