Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 22: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops-test.cc@124 PS22, Line 124: op->UpdateStats(&stats_); : ASSERT_FALSE(stats_.runnable()); : ASSERT_EQ(min_value, c->histogram()->MinValue()); : ASSERT_EQ(mean_value, c->histogram()->MeanValue()); : ASSERT_EQ(max_value, c->histogram()->MaxValue()); : ASSERT_EQ(total_count, c->histogram()->TotalCount()); : ASSERT_EQ(total_sum, c->histogram()->TotalSum()); nit: This 'UpdateStats' just modified the stats_, it didn't modify compaction_metrics_ in any case. Maybe we should verify the value of these metrics hasn't been changed in tablet_server-test or somewhere. But I think the verification of stats_.runnable() is enough. -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 22 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 11 Jan 2022 08:04:12 +0000 Gerrit-HasComments: Yes
