KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compaction on the specified table ...................................................................... Patch Set 24: (3 comments) http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG@9 PS22, Line 9: , we can disable the : compaction of the table's data, which can im > Well, I meant dropping/removing the part of the sentence which was Done http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet.cc@1747 PS23, Line 1747: if (metadata_->extra_config() && metadata_->extra_config()->has_disable_compaction()) { : return metadata_->extra_config()->disable_compaction(); : } : return false; : } > nit: what do you think of going a bit further and getting rid of the 'disab Done http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet_mm_ops.cc@134 PS23, Line 134: Substitute("Rowset compaction is disabled (check --enable_rowset_compaction" : "and disable_compaction in extra_config for tablet:$0)", tablet_->tablet_id()); : stats->set_runnable(false); > Do you mind using Substitute() to construct the log messages here and below Done -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 24 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 12 Jan 2022 08:55:49 +0000 Gerrit-HasComments: Yes
