Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compaction on the specified table ...................................................................... Patch Set 23: Code-Review+1 (3 comments) Thank you for addressing those! LGTM with a few more nits to take care of. http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG@9 PS22, Line 9: , we can drop it since : it doesn't seem relevant. By disable the com > Done Well, I meant dropping/removing the part of the sentence which was ... with only a few queries and will be migrated to HDFS in a short time ... :) The idea was that the mentioned use case was specific to a particular workload, but the newly added feature can be used in many other scenarios. http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet.cc@1747 PS23, Line 1747: bool disable_compaction = false; : if (metadata_->extra_config() && metadata_->extra_config()->has_disable_compaction()) { : disable_compaction = metadata_->extra_config()->disable_compaction(); : } : return disable_compaction; nit: what do you think of going a bit further and getting rid of the 'disable_compaction' variable as well? It might be something like bool Tablet::disable_compaction() const { if (metadata_->extra_config() && metadata_->extra_config()->has_disable_compaction()) { return metadata_->extra_config()->disable_compaction(); } return false; } http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/18054/23/src/kudu/tablet/tablet_mm_ops.cc@134 PS23, Line 134: "Rowset compaction is disabled (check --enable_rowset_compaction" : " and disable_compaction in extra_config for tablet:" : << tablet_->tablet_id() << ")" Do you mind using Substitute() to construct the log messages here and below? Using Substitute() is better from the code readability perspective. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 23 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 12 Jan 2022 05:57:36 +0000 Gerrit-HasComments: Yes
