KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compaction on the specified table ...................................................................... Patch Set 23: (14 comments) http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG@7 PS22, Line 7: compact > compaction Done http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG@9 PS22, Line 9: , we can drop it since : it doesn't seem relevant. By disable the com > Drop this since it doesn't seem relevant. Done http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG@11 PS22, Line 11: iency (the effect is more > This name for the attribute seems to be out-of-date? Done http://gerrit.cloudera.org:8080/#/c/18054/22//COMMIT_MSG@10 PS22, Line 10: f the table's : data, which can improve the se > disable the compaction of the table's data Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/common/common.proto@476 PS22, Line 476: If set true, the table's data on disk is no > How about: Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/common/wire_protocol.cc@688 PS22, Line 688: kTableDisableCompact > nit: rename kTableDisableCompact --> kTableDisableCompaction ? Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/integration-tests/alter_table-test.cc@379 PS22, Line 379: CheckDisableCompact > nit: rename CheckDisableCompact --> CheckDisableCompaction Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/integration-tests/alter_table-test.cc@2535 PS22, Line 2535: Set disable_compaction false. > nit: maybe, replace with Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet.cc@1748 PS22, Line 1748: if (metadata_->extra_con > That should have been a pointer, not a reference to a pointer, right? Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops-test.cc@107 PS22, Line 107: ar > are Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops-test.cc@112 PS22, Line 112: ar > are Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops-test.cc@172 PS22, Line 172: DisableCompact > Here and in other places: rename DisableCompact --> DisableCompaction. Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops.cc@116 PS22, Line 116: DisableCompact > Rename DisableCompact --> DisableCompaction Done http://gerrit.cloudera.org:8080/#/c/18054/22/src/kudu/tablet/tablet_mm_ops.cc@135 PS22, Line 135: disable_compaction in extra_config > For this and all the updated messages below: prior to this update, the log Done -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 23 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 12 Jan 2022 03:53:43 +0000 Gerrit-HasComments: Yes
