Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18577 )
Change subject: [build] Skip to check TSAN dependencies when build in non-TSAN mode ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@9 PS2, Line 9: the dist-test uses the same servers to build different : patches dist-test doesn't build anything, it just uploads the binaries and their dependencies to the test servers. http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@10 PS2, Line 10: I've ever built : a librocksdb.so incorrectly dependent libstdc++ by I'm not sure I can parse this. What do you mean? http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@15 PS2, Line 15: This patch skip to check TSAN dependencies when build in non-TSAN mode What's the exact error you got from the post-flight script? We have many other components which works as needed, and those are part of the thirparty. Maybe, you need to build both TSAN and non-TSAN version of rocksdb in thirdparty to make this work? http://gerrit.cloudera.org:8080/#/c/18577/2/thirdparty/postflight.py File thirdparty/postflight.py: http://gerrit.cloudera.org:8080/#/c/18577/2/thirdparty/postflight.py@90 PS2, Line 90: if argv[1] == 1: I don't think it's a good idea to simply rely on the number of command-line parameters, without even looking at them. -- To view, visit http://gerrit.cloudera.org:8080/18577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8101dea0cd039392dbbc889e66e7a4259dc1b9c2 Gerrit-Change-Number: 18577 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Jun 2022 04:13:31 +0000 Gerrit-HasComments: Yes
