Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18577 )
Change subject: [build] Skip to check TSAN dependencies when build in non-TSAN mode ...................................................................... Patch Set 4: Code-Review+1 (7 comments) Thank you for the patch! http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@10 PS2, Line 10: I've ever built : a librocksdb.so incorrectly dependent libstdc++ by > I‘ve ever submit this CR https://gerrit.cloudera.org/c/18569/, it added the Thank you for the explanation. Yes, the Jenkins' workspaces might be cross-polluted because they are reused from one build to another in an attempt to avoid re-building thirdparty again and again. I cleaned them up using the http://jenkins.kudu.apache.org/job/clean-workspaces/ job. Usually, that's not a big problem since changes in the thirdparty happen rarely. http://gerrit.cloudera.org:8080/#/c/18577/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18577/4//COMMIT_MSG@10 PS4, Line 10: I've ever built : a librocksdb.so incorrectly dependent libstdc++ by : https://gerrit.cloudera.org/c/18241/ Yep, that's built by Jenkins machines -- it doesn't matter what happens in your local workspace. Probably, if you try building your patch with old release of Linux, you could see that as well. Since the build machines might use older version of libtools, etc., it could be something that described in the commit description for https://github.com/apache/kudu/commit/3625a0c1704fad8302d0aa0801033d3be5287f00 http://gerrit.cloudera.org:8080/#/c/18577/3/thirdparty/postflight.py File thirdparty/postflight.py: http://gerrit.cloudera.org:8080/#/c/18577/3/thirdparty/postflight.py@99 PS3, Line 99: Skip to check TSAN dependencies nit: Skipping the check of TSAN dependencies http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py File thirdparty/postflight.py: http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@90 PS4, Line 90: --in_tsan nit: why not just '--tsan'? http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@91 PS4, Line 91: with in http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@91 PS4, Line 91: version configuration http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@99 PS4, Line 99: Skip to check TSAN dependencies nit: Skipping the check of TSAN dependencies -- To view, visit http://gerrit.cloudera.org:8080/18577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8101dea0cd039392dbbc889e66e7a4259dc1b9c2 Gerrit-Change-Number: 18577 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jun 2022 00:38:09 +0000 Gerrit-HasComments: Yes
