Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18577 )

Change subject: [build] Skip to check TSAN dependencies when build in non-TSAN 
mode
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@9
PS2, Line 9: the jenkins uses the same servers to build different
           : patches
> dist-test doesn't build anything, it just uploads the binaries and their de
got it


http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@15
PS2, Line 15: This patch skip to check TSAN dependencies when build in non-TSAN 
mode
> What's the exact error you got from the post-flight script?  We have many o
Same to above.


http://gerrit.cloudera.org:8080/#/c/18577/2/thirdparty/postflight.py
File thirdparty/postflight.py:

http://gerrit.cloudera.org:8080/#/c/18577/2/thirdparty/postflight.py@90
PS2, Line 90: p.add_argument("
> I don't think it's a good idea to simply rely on the number of command-line
Done



--
To view, visit http://gerrit.cloudera.org:8080/18577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8101dea0cd039392dbbc889e66e7a4259dc1b9c2
Gerrit-Change-Number: 18577
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 01 Jun 2022 08:51:52 +0000
Gerrit-HasComments: Yes

Reply via email to