Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18577 )
Change subject: [build] Skip to check TSAN dependencies when build in non-TSAN mode ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/build-thirdparty.sh@120 PS4, Line 120: if [ -n "$F_TSAN" ]; then : $TP_DIR/postflight.py --in_tsan : else : $TP_DIR/postflight.py : fi nit: maybe, instead of different ways of calling postflight script, build the list of arguments for the script. That is more expressive and clean. That's something like: local postflight_args= if [ -n "$F_TSAN" ]; then postflight_args="$postflight_args --tsan" fi $TP_DIR/postflight.py $postflight_args -- To view, visit http://gerrit.cloudera.org:8080/18577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8101dea0cd039392dbbc889e66e7a4259dc1b9c2 Gerrit-Change-Number: 18577 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jun 2022 00:46:35 +0000 Gerrit-HasComments: Yes
