Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18577 )
Change subject: [build] Skipping the check of TSAN dependencies when build in non-TSAN configuration ...................................................................... Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18577/2//COMMIT_MSG@10 PS2, Line 10: e time, : but it might introduce cross-pollution. > Thank you for the explanation. Thanks for the explanation. It's my first time to know the Jenkins clean-workspaces job. http://gerrit.cloudera.org:8080/#/c/18577/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18577/4//COMMIT_MSG@10 PS4, Line 10: e time, : but it might introduce cross-pollution. : > Yep, that's built by Jenkins machines -- it doesn't matter what happens in Got it! http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/build-thirdparty.sh@120 PS4, Line 120: local postflight_args= : if [ -n "$F_TSAN" ]; then : postflight_args="$postflight_args --tsan" : fi : $T > nit: maybe, instead of different ways of calling postflight script, build t Done http://gerrit.cloudera.org:8080/#/c/18577/3/thirdparty/postflight.py File thirdparty/postflight.py: http://gerrit.cloudera.org:8080/#/c/18577/3/thirdparty/postflight.py@99 PS3, Line 99: Skipping the check of TSAN depe > nit: Done http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py File thirdparty/postflight.py: http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@90 PS4, Line 90: --tsan", > nit: why not just '--tsan'? Done http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@91 PS4, Line 91: in T > in Done http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@91 PS4, Line 91: nfigura > configuration Done http://gerrit.cloudera.org:8080/#/c/18577/4/thirdparty/postflight.py@99 PS4, Line 99: Skipping the check of TSAN depe > nit: Done -- To view, visit http://gerrit.cloudera.org:8080/18577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8101dea0cd039392dbbc889e66e7a4259dc1b9c2 Gerrit-Change-Number: 18577 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jun 2022 03:50:22 +0000 Gerrit-HasComments: Yes
