Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/18473/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18473/7//COMMIT_MSG@12 PS7, Line 12: dispensor dispenser? http://gerrit.cloudera.org:8080/#/c/18473/7//COMMIT_MSG@15 PS7, Line 15: reply rely? http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h File src/kudu/util/mini_oidc.h: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@20 PS7, Line 20: nit: remove the extra line http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@41 PS7, Line 41: std::string expiration_time; nit: would be great to document this field as well BTW, why do we need both expiration_time (especially as a string) and 'lifetime_ms'? http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc File src/kudu/util/mini_oidc.cc: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@94 PS7, Line 94: oidc_server_ What if oidc_server_ is nullptr because Start() returned an error before line 129? http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@95 PS7, Line 95: jwks_server_ What if jwks_server_ is nullptr since the Start() method hasn't been called for this instance? -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 00:25:00 +0000 Gerrit-HasComments: Yes
