Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h File src/kudu/util/mini_oidc.h: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@47 PS7, Line 47: // Serves the following endpoints: nit: for testing cluster http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@78 PS7, Line 78: static std::string CreateJwt nit: comments for the functionality http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@80 PS7, Line 80: is_valid is_valid_key_id or is_valid_key? http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc File src/kudu/util/mini_oidc.cc: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@1 PS7, Line 1: nit: extra space http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@110 PS7, Line 110: 'kid_1' points at a valid key, while 'kid_2' points at an declare kKid1 and kKid2 -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 01:29:44 +0000 Gerrit-HasComments: Yes
